Overwrite Extraction with Original Folder Structure #212
Conversation
There was a problem hiding this comment.
@mega5800 Great work here. I love the tests! I added a comment to one line that I think we should consider. Let me know what you think.
…ter description and readability
|
also, please update the branch (you can use the github ui to update it and then pull it again locally from your own branch). |
|
@mega5800 Let me know if you have concerns or if there is some way I can help you get this merged. I would like the simplification done, but I can do it if it is too much of a burden for you right now. I appreciate your contributions and I do not want to cause you trouble! |
|
Hello @activescott. I am currently away and will work on your comments next week. Happy new year! |
chore: suggested simplification proposal
|
Hello @activescott. As you requested, I updated my pull request according to the latest master branch in the main LessMSI repo, accepted your code improvement and made sure we pass all the tests. I’ve also replied to your comment regarding the change in the Core project.Please let me know if you have any additional comments about that topic. Besides that, I think we are ready for a merge. Thank you. |
|
🎉 This PR is included in version 2.4.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
👍🎉 First off, thanks for taking the time to contribute! 🎉👍
Please fill out the following checklist:
If you need any help at all, feel free to submit the PR and @-mention activescott and I'll be happy to assist!
Hello @activescott.
I took care of this ticket.
I implemented a logic for detecting and deleting any duplicate files after a file extraction.
I added some tests to cover this feature from different points of view, such as regular extraction, extraction with a defined path and an extraction with specific files.
The newly added tests use a new MSI file I added called “AppleMobileDeviceSupport64.msi”.
I know this file contains duplicate files, thus making it a prefect match for testing this new overwrite extraction.
I’d greatly appreciate if you could review my pull request.
Thank you.
fixes #167